Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround null & mixed being ReservedWords #1817

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Workaround null & mixed being ReservedWords #1817

merged 1 commit into from
Jan 4, 2022

Conversation

fbourigault
Copy link
Contributor

Symfony 6 added return types to most of it's signatures.

This is reported as ReservedWords by Psalm.

See vimeo/psalm#7026 and doctrine/dbal#5053 for more context.

Symfony 6 added return types to most of it's signatures.

This is reported as ReservedWords by Psalm.

See vimeo/psalm#7026 and doctrine/dbal#5053 for more context.
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #1817 (ef3a63c) into master (5930bad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1817   +/-   ##
=========================================
  Coverage     87.83%   87.83%           
  Complexity     7836     7836           
=========================================
  Files           281      281           
  Lines         22748    22748           
=========================================
  Hits          19981    19981           
  Misses         2767     2767           
Flag Coverage Δ
5-max 87.83% <ø> (ø)
7.4 87.83% <ø> (ø)
agnostic 68.54% <ø> (ø)
mysql 70.53% <ø> (ø)
pgsql 70.42% <ø> (ø)
sqlite 68.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5930bad...ef3a63c. Read the comment docs.

@dereuromark dereuromark merged commit 934b8de into propelorm:master Jan 4, 2022
@fbourigault fbourigault deleted the psalm-reserved-words branch January 4, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants